search

nlaha / godot-midi

MIDI file parsing and event playback in Godot 4.1+
MIT License
52 stars 5 forks source link

Trying to get the game to be runnable straight away on Godot 4.2 #16

Closed xanmankey closed 4 months ago

xanmankey commented 4 months ago

So I added the bin directory with the built executables and removed them from the .gitignore; the project does work, but only on the second try. I'm not sure if the issue for that is with godot 4 or the plugin itself (from what I've seen at https://github.com/godotengine/godot/issues/77007, it seems like the initial import process is causing a circular dependency on linux). Maybe a README could be added to the /game directory or a line mentioning the import issue and to just try closing and reopening the project after initial import

nlaha commented 4 months ago

The binary (.so, .dll, etc.) files are not included in the git history by design. Those are either generated by your compiler if building from source, or downloaded from the releases tab in GitHub. Because this extension is a C++ GDExtension, it will not work without the binary files, please check that you have the following files in /game/addons/godot_midi/bin:

libgdgodotmidi.linux.template_debug.x86_64.so libgdgodotmidi.linux.template_release.x86_64.so

xanmankey commented 4 months ago

Gotcha, in that case I'll close this. I was cloning the repo, no wonder it wasn't working.

nlaha commented 4 months ago

I have noticed a similar issue where the project loads before the midi file is actually imported. So I think you're on to something here. Restarting the editor seems to fix it, but I'm going to post an issue anyways: https://github.com/nlaha/godot-midi/issues/18