dataGridView:gridFooterViewForColumn is not truly optional

nlampi / SwiftGridView

Swift based data grid view.

MIT License

58 stars 15 forks source link

dataGridView:gridFooterViewForColumn is not truly optional #12

Closed robcecil closed 7 years ago

robcecil commented 7 years ago

The protocol func is marked as optional, but without an implementation, it will crash.

Shouldn't the Grid implementation not assume the SwiftGridViewDataSource implementation will actually use this?

nlampi commented 7 years ago

Hi @robcecil Can you provide some more details on this (iOS version, etc) Can you also make sure that you are not passing a height for the footer (heightForGridFooterInDataGridView)?

robcecil commented 7 years ago

I had been just modifiying your example and trying to simplify it down (removing footer, etc).

So when I comment out the heightForGridFooterInDataGridView implementation, it works.