search

nlampi / SwiftGridView

Swift based data grid view.
MIT License
58 stars 15 forks source link

Grouping header issue #32

Closed vlapra closed 6 years ago

vlapra commented 6 years ago

There is an error at SwiftGridView file at line 823. It takes care only about first two columns of a group.

for column in grouping[0] ... grouping[1] { colWidth += self.delegate!.dataGridView(self, widthOfColumnAtIndex: column) }

It should be

for column in grouping { colWidth += self.delegate!.dataGridView(self, widthOfColumnAtIndex: column) }

nlampi commented 6 years ago

Column grouping works off of the column index for the first and last column of the group. This adds up the width for all column in between. I see now that the documentation/error checks for this might be insufficient and I can add some more for that.

vlapra commented 6 years ago

Thanks a lot. It was my misunderstanding:(

Great job!

Thanks V.

    1. 2018 v 0:04, Nathan Lampi notifications@github.com:

Column grouping works off of the column index for the first and last column of the group. This adds up the width for all column in between. I see now that the documentation/error checks for this might be insufficient and I can add some more for that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.