Batch 3 fixes.

[kalaspuffar]

Hi @josteinaj

• Remove class attribute notebody
• aside should be used for body footnotes (one aside element per footnote) only, endnotes should be in a list along the lines set out by http://kb.daisy.org/publishing/docs/html/notes.html
• Update poem section to reflect new guidelines

New guidelines for poems

• Poetry, song lyrics or any content written in verse, where lines of text must be preserved just as they are in the source material, is required to be marked up with <div class="verse">.
• Each group of lines of text must be contained in a separate <p class="linegroup"> element and each line of text must be marked up with <span class="line">. HTML line breaks, <br/>, must be added between consecutive lines within a line group. Indented lines may be marked up using <span class="line_indent"> or <span class="line_longindent">. *Line numbers must only be included if specific instructions are given about it, even if they are present in the source material. If line numbers are to be included, they must be marked up with <span class="linenum">.
• If the content written in verse has a title it may be handled as a normal heading, with <section> elements wrapping the content. However, if it does not make sense to use a heading, it may be marked up with <p class="verse-title"> and placed within the <div class="verse"> container. This option must not be used unless specific instructions are given by the Ordering Agency.
• If there is an author name placed under the verse it may be marked up with <p class="verse-author"> and placed at the end of the <div class="verse"> container.

Best regards Daniel

[josteinaj]

I was not aware of the <p class="verse-title"> markup. Wouldn't it make sense to mark it as a bridgehead instead? Or as an option? @AndersEkl @martinpub

[AndersEkl]

I was not aware of the <p class="verse-title"> markup. Wouldn't it make sense to mark it as a bridgehead instead? Or as an option? @AndersEkl @martinpub

It does, yes. @martinpub , maybe we should change this right away? Using bridgehead.

[kalaspuffar]

Hi @AndersEkl and @martinpub

I've changed the implementation to use bridgehead. Easy to revert that change if needed.

Best regards Daniel

[josteinaj]

@martinpub @AndersEkl This is more of a guidelines question and not really a validator question: I'm curious about what the difference is between line_indent and line_longindent? Are there three types of indentation in poems (not indented, somewhat indented, severely indented)? It is not described in the guidelines as far as I can tell, but it might be more obvious to those ordering and producing the EPUBs than me.

[kalaspuffar]

Hi @josteinaj

I've done the simple changes that don't require input from @AndersEkl or @martinpub.

Best regards Daniel

[AndersEkl]

@martinpub @AndersEkl This is more of a guidelines question and not really a validator question: I'm curious about what the difference is between line_indent and line_longindent? Are there three types of indentation in poems (not indented, somewhat indented, severely indented)? It is not described in the guidelines as far as I can tell, but it might be more obvious to those ordering and producing the EPUBs than me.

Yes, the idea is to have a few options to represent the visual layout of poems in printed form. There are all sorts of variants with indentations of differing length and other fanciful ideas, but we thought that having at least one short and one long indentation would be a good compromise. We mentioned these classes in the guidelines but haven't gone into detail exactly how to use them. This should be specified in editing instructions.

[kalaspuffar]

Hi @josteinaj

Are you still waiting for an update from me? Read through this issue, and I don't think we have any outstanding questions? Or is there something I've missed?

Best regards Daniel

[josteinaj]

Hi @kalaspuffar. No I'm not waiting on you. We're waiting on feedback from @AndersEkl and @martinpub regarding:

• ordering of bridgehead(s) / linegroup(s) / author(s)
• presence and validation of linenum/line

[AndersEkl]

I gave my thoughts above...

• I don't think it is important to have strict rules for the order of bridgehead(s), linegroup(s) and author(s).
• Line numbers should be a the start of a line, but otherwise I don't think we need many other rules. There can be cases where a line only has a number, and nothing else. There are also lots of cases where for instance every fifth line is numbered. So, I think we need a quite relaxed approach here.

[josteinaj]

Ok.

So if we're quite relaxed about the ordering of bridgehead(s) / linegroup(s) / author(s), should we at least require a minimum of one linegroup? For instance: "any number of bridgehead, linegroup and author in any order, but at least one linegroup". My suggestion here should work I think: https://github.com/nlbdev/nordic-epub3-dtbook-migrator/pull/427#discussion_r581790075

For lines, we can be relaxed about that as well, in which case it's fine the way it is now. Just note that since these are inline elements, the CSS rules might become more complex if we have to account for linenums without a corresponding line element, unnumbered lines in the same linegroup as numbered lines, etc.

By the way, could it make sense to require both "line" and "line_indent"/"line_longindent" together? Indentation styles could be attached to the line_indent and line_longindent classes, while CSS rules common to all lines, as well as cases where we want to search for or match lines regardless of their indentation, could use simply "line".

So for instance:

<span class="line line_indent">…</span>

?

[martinpub]

I think your suggestions seem reasonable @josteinaj

[AndersEkl]

Yep, I agree!

[kalaspuffar]

Hi @josteinaj

Did minor changes to the poem rules. Now we allow the author or bridgehead before or after at least one line of the poem. The line contains tags with one or more of the classes line, line_indent or line_longindent.

Best regards Daniel