Fixing pagebreak and image logic

nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.

http://nlbdev.github.io/nordic-epub3-dtbook-migrator/

GNU Lesser General Public License v2.1

8 stars 7 forks source link

Fixing pagebreak and image logic #434

Closed kalaspuffar closed 3 years ago

kalaspuffar commented 3 years ago

Hi @josteinaj

I've looked at the issues that are most common in the test books and changed accordingly.

Pagebreaks uses aria-label for page number instead of title
Logic for extension of image types works better with ends-with logic.

Best regards Daniel

josteinaj commented 3 years ago

Looks good.

@kalaspuffar It seems you weren't invited to this repo. I've invited you now and given you "maintainer" permissions, so you should be able to do whatever needs to be done with this repo.

Do you get a clickable "Rebase and merge" button? Can you click it and see if it works for you?

josteinaj commented 3 years ago

I've also enable building of all tags on Docker Hub now by the way. Maybe you should try creating a tag and see if it works for you. For instance tag "test.2021-03-18" or something.

kalaspuffar commented 3 years ago

merge

No, I don't have that access. I've tried logging out and in again.

josteinaj commented 3 years ago

You have a pending invitation. I think you can find it here: https://github.com/nlbdev/nordic-epub3-dtbook-migrator/invitations

kalaspuffar commented 3 years ago

Hi @josteinaj

Missed that email. Seems to work fine.

Best regards Daniel

josteinaj commented 3 years ago

Great, then you should have the permissions you need now :+1: