Class "sidebar" is deprecated and should not be allowed

nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.

http://nlbdev.github.io/nordic-epub3-dtbook-migrator/

GNU Lesser General Public License v2.1

8 stars 7 forks source link

Class "sidebar" is deprecated and should not be allowed #458

Closed martinpub closed 3 years ago

martinpub commented 3 years ago

E.g.: <aside class="sidebar" role="doc-example" epub:type="sidebar" id="sidebar_6"> is currently valid. "sidebar" is replaced by "text-box" in the new 2020-1 guidelines, so should be disallowed.

Also, epub:type "sidebar" is deprecated according to https://idpf.github.io/epub-vocabs/structure/ (the semantics are captured by <aside>), so perhaps it shouldn't be allowed either. But I'm not sure about how strictly we check epub:type values currently.

martinpub commented 3 years ago

Ping @kalaspuffar, if you could look at this?

martinpub commented 3 years ago

Class value "sidebar" is now disallowed with #465, however I think the epub:type value "sidebar" is still allowed? Should we disallow it too, @AndersEkl? It is listed as deprecated in https://idpf.github.io/epub-vocabs/structure/.

martinpub commented 3 years ago

Solved in #469