search

nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

Adding the section type acknowledgments. #489

Closed kalaspuffar closed 3 years ago

kalaspuffar commented 3 years ago

Hi @martinpub

This PR aims to solve the issue #487.

As a side note it would improve the process if you are able to create a commit / PR with an updated test book. Half the battle is to figure out how to add these constructs in the correct manor. And in some cases the specification is not clear either. In this case I was wondering if the acknowledgment could be a part of a backmatter file or if it needed to be a separate file. I opted to creating a new file.

As you are the expert on the format you could easily change the book to another valid state and then I change the validator so it will accept that state. Could also be good as a discussion point if we are unsure about the correct markup.

Just a thought.

Best regards Daniel

martinpub commented 3 years ago

Thank you very much @kalaspuffar!

And of course, adding to the test book is of course something I could provide you with.