search

nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

First implementation of backlink testing. #509

Closed kalaspuffar closed 1 year ago

kalaspuffar commented 2 years ago

Trying to solve #478

kalaspuffar commented 2 years ago

Hi @josteinaj

Thank you for the review. I've updated the code after your suggestions.

Best regards Daniel

josteinaj commented 2 years ago

Looks good!

@martinpub How should be handle backlinks in books with multiple noterefs referencing the same note? I assume that's not too uncommon?

josteinaj commented 2 years ago

I think we need to solve the case of multiple noterefs referencing the same note before we merge this.

martinpub commented 2 years ago

OK @josteinaj. I think that is a topic for clarification in the next guidelines revision. I made a ticket in https://github.com/nlbdev/epub3-guidelines-update/issues/150. @AndersEkl and I were discussing a plan for a minor/clarification release, but our idea was to first review the current backlog of items in the guidelines repo, then get to work/involve the group. We had to reschedule, but our intent is to get to it in the coming weeks. So it's good that this issue is logged, thanks!

josteinaj commented 1 year ago

The conclusion is that there must be exactly one note reference for each note (see https://github.com/nlbdev/epub3-guidelines-update/issues/150).

kalaspuffar commented 1 year ago

@josteinaj Made the requested text changes.

josteinaj commented 1 year ago

Merged into master in 15daadbc5fc213b9327fc0ddaa2df7c4603332cf