search

nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

Updating Docker commands #514

Closed martinpub closed 2 years ago

martinpub commented 2 years ago

Hi @josteinaj, I updated to the Docker commands last known to work for me. Do you think the parameters are OK? I think the linking method was needed for proper exposure of web service on a Windows host. This is also one of the examples at the DAISY Pipeline 2 web page.

martinpub commented 2 years ago

Hi @josteinaj, is this change OK according to you?

josteinaj commented 2 years ago

--pull always is not strictly needed for tagged images. It was a good idea for :guidelines-revision, or if you use :latest.

--link is neat. I didn't know about it. Together with -v webui-data:/opt/daisy-pipeline2-webui/data I see it lets you run the engine in local mode, to avoid having to zip and POST all the data between the containers as HTTP requests. However, it seems to be "a legacy feature of Docker, [and] may eventually be removed". So in the future we may have to change it.

--detach I guess is a matter of taste? I like seeing the output, but maybe that's because I like to be able to debug it. With --detach you can close the terminal window etc.

I'm fine with the changes. I've tested that they work for me. So I'm merging them.

martinpub commented 2 years ago

Thanks for the input @josteinaj! And the merge. We can leave this as is for now, but can always adjust later if needed.