nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

No check for aria-describedby linking in text extractions/image descriptions #519

Closed martinpub closed 1 year ago

martinpub commented 2 years ago

The 2020-1 guidelines require text extractions/image descriptions to be put in a child aside element inside the figure, with proper linking between the img element and the aside using aria-describedby. However, there seems to be no check for aria-describedby linking in the validator.

The example from the guidelines would currently still be valid if aria-describedby is omitted, which would result in missing accessibility semantics and potentially rendering/skippability issues in reading systems.

A fix should introduce the following checks:

  1. That aria-describedby is present on the img element of the figure
  2. Link integrity from the aria-describedby reference to a matching fig-desc aside in the same figure container
josteinaj commented 2 years ago

I'm starting my vacation this weekend. I'll be working a bit during week 29 (July 18th - July 22nd), so if there's a PR by then, I can have a look at it and hopefully make a release. Otherwise I'll be back from vacation August 9th, so I can look more at it during August.

martinpub commented 2 years ago

Thanks @josteinaj! I think the time frame is OK, most people will be on vacation, just wanted to log this for now. Enjoy your vacation!

josteinaj commented 1 year ago

@martinpub @kalaspuffar solved?

kalaspuffar commented 1 year ago

To my knowledge, yes.