nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

doc-noteref not required on noteref elements, but should #520

Closed martinpub closed 1 year ago

martinpub commented 2 years ago

The validation rules for 2020-1 currently allow omitting @role="doc-noteref" on noteref <a> elements. Hopefully this will be caught by ACE, but as it is specified in the 2020-1 guidelines explicitly, I think it should be added to the list of required attributes of a noteref element. I think it's around here in the RelaxNG schema.

Possibly, specific checks of other role values in other contexts should also be added, but I haven't looked into that.

josteinaj commented 1 year ago

@martinpub @kalaspuffar solved?

kalaspuffar commented 1 year ago

To my knowledge, yes.