search

nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

Check that the extracted text has a described by link #527

Closed kalaspuffar closed 1 year ago

kalaspuffar commented 1 year ago

Trying to solve https://github.com/nlbdev/nordic-epub3-dtbook-migrator/issues/519

kalaspuffar commented 1 year ago

Hi @josteinaj

I've added the test code I ran in the old repository. I now have this repository setup to run the java test directly in this repository. We might want to remove the generated XSLT files, though, to ease the review process. I'll look into that.

Best regards Daniel

kalaspuffar commented 1 year ago

I'm sorry that this PR is a bit messy but future ones will be more clean.

josteinaj commented 1 year ago

After thinking about it, this looks good. Are we ready to merge?

kalaspuffar commented 1 year ago

Hi @josteinaj

Yes, this PR is ready to merge. I will create another convenience PR as well that you might want to merge later.

Best regards Daniel

kalaspuffar commented 1 year ago

Hi @erikmtm

Do you want to review this as well?

Best regards Daniel

josteinaj commented 1 year ago

I'm merging this.

@erikmtm: if you have comments, we can always change it later :+1: