nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

Loosen the requirement of NCX file and change the issue reporting logic. #533

Closed kalaspuffar closed 1 year ago

kalaspuffar commented 1 year ago

Hi @josteinaj

This PR will solve two separate issues.

Not sure why it was implemented this way, it might have been an old request for change or a misunderstanding on my part about what the "report" rules in the schema were reporting.

But now I've changed it so all reported issues assert, reports, or general failures will end in the validator exiting with 1 as an error code, and all these will be counted as the general total issues.

Moreover, I've removed the requirements of an NCX file reported by the schema. The specification https://github.com/kalaspuffar/nordic-epub3-dtbook-migrator/pull/new/loosen_requirement_of_ncx states that this is valid but not required.

I also added some convenience gitignores.

Best regards Daniel