nlbdev / nordic-epub3-dtbook-migrator

Tools for converting between a strict subset of DTBook and EPUB3.
http://nlbdev.github.io/nordic-epub3-dtbook-migrator/
GNU Lesser General Public License v2.1
8 stars 7 forks source link

2020-1 EPUBs with PNG cover images (cover.png) do not validate #555

Closed keyvantextalk closed 1 year ago

keyvantextalk commented 1 year ago

2020-1 guidelines, under Image File Naming and Directory Structure, state that the cover image should be cover.png or cover.jpg.

An exception to this is the cover image, which should be named simply cover.png or cover.jpg.

And under Cover:

The front cover, when available, must be captured as a .jpg or .png image file and given the name cover.jpg/png.

But the validation rules produce the following error when validating a 2020 EPUB with cover.png:

[opf15b] The image with property value 'cover-image' must have the filename 'cover.jpg': (<item href="images/cover.png" id="coverimg" media-type="image/png" properties="cover-image">)

martinpub commented 1 year ago

Hi @keyvantextalk! OK, this seems like a bug then. We did open up for PNGs with 2020-1 (only JPEG images were allowed in 2015-1), and there should not be a difference when it comes to cover images, so the rule should be updated to follow the 2020-1 text.

keyvantextalk commented 1 year ago

Thanks @martinpub! Okay, will wait for rule update then 👍

keyvantextalk commented 1 year ago

Fixed by #558