nlbdev / pipeline

NLB branch of the super-project that aggregates all Pipeline related code. See https://github.com/daisy/pipeline for the main branch.
http://repo.nlb.no/pipeline
3 stars 1 forks source link

Lists with markup <pl> shall have layout as<ul> og <ol> #132

Closed KariRudjord closed 7 years ago

KariRudjord commented 7 years ago

That is: start from left marin. When text is more than one row, text start with 2 indents from row 2.

josteinaj commented 7 years ago

Does this not work? I have a test for it that passes:

input:

<list type="pl">
    <li>content content content content content content content content</li>
    <li>content content content content content content content content</li>
    <li>content</li>
    <li>content</li>
    <li>content</li>
    <li>content</li>
    <li>content</li>
    <li>content</li>
    <li>content</li>
    <li>content content content content content content content content</li>
</list>

output:

<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row>⠀⠀⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞</row>
<row/>
josteinaj commented 7 years ago

...or maybe it's an EPUB issue? There's no test for that currently.

matskober commented 7 years ago

If you skipped to left margins ?

⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞

On 20 October 2017 at 13:39, Jostein Austvik Jacobsen < notifications@github.com> wrote:

...or maybe it's an EPUB issue? There's no test for that currently.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nlbdev/pipeline/issues/132#issuecomment-338195062, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpMMu26c3o5YkxQPR1CgvLM5IzfhhCYks5suJSWgaJpZM4QAaDv .

matskober commented 7 years ago

two ...

On 20 October 2017 at 13:58, Mats Køber mats.kober@gmail.com wrote:

If you skipped to left margins ?

⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞ ⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞ ⠀⠀⠉⠕⠝⠞⠑⠝⠞⠀⠉⠕⠝⠞⠑⠝⠞

On 20 October 2017 at 13:39, Jostein Austvik Jacobsen < notifications@github.com> wrote:

...or maybe it's an EPUB issue? There's no test for that currently.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nlbdev/pipeline/issues/132#issuecomment-338195062, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpMMu26c3o5YkxQPR1CgvLM5IzfhhCYks5suJSWgaJpZM4QAaDv .

josteinaj commented 7 years ago

All pages have a two-cell gap at the left. Probably to allow for page markers. So you can disregard the two first cells in my example for this particular issue, since those cells are not really part of how the list is styled. If we removed that margin, we would get the same as your example.

matskober commented 7 years ago

ok. Do it do this a standard? If I wouldn't want them; would I have "to go negative" on the margin? (-2?)

Mats

On 20 October 2017 at 14:05, Jostein Austvik Jacobsen < notifications@github.com> wrote:

All pages have a two-cell gap at the left. Probably to allow for page markers. So you can disregard the two first cells in my example for this particular issue, since those cells are not really part of how the list is styled. If we removed that margin, we would get the same as your example.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nlbdev/pipeline/issues/132#issuecomment-338200570, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpMMi5oCKviOYSloEFFHJVZTW7Q1Iplks5suJqBgaJpZM4QAaDv .

josteinaj commented 7 years ago

The current rule looks like this:

@page {
        margin-right: 1;
        @if $show-print-page-numbers {
            margin-left: 2;
        } @else {
            margin-left: 1;
        }
}

So there's always 1 empty cell on both the left and right side of the page. And if the show-print-page-numbers option is enabled (which it is by default), then there's 2 empty cells on the left (i.e. an empty column used for page markers).

You could try disabling the show-print-page-numbers option and adding this CSS to remove the margin altogether:

@page {
        margin-left: 0;
}
KariRudjord commented 7 years ago

Empty row over table is put into CSS.