search

nlbdev / pipeline

NLB branch of the super-project that aggregates all Pipeline related code. See https://github.com/daisy/pipeline for the main branch.
http://repo.nlb.no/pipeline
3 stars 1 forks source link

Improve english hyphenation #154

Closed KariRudjord closed 6 years ago

KariRudjord commented 6 years ago

Job 1766 gets hyphenation like this t-hemes fis-herman t-hat

bertfrees commented 6 years ago

Is this with Norwegian (force-norwegian) or English braille rules?

KariRudjord commented 6 years ago

The whole book is marked xml lang en so I think english braille rules

bertfrees commented 6 years ago

The "force-norwegian" option is important here.

KariRudjord commented 6 years ago

I thought that if the whole book is marked en it would be turned off? Maybe I'm wrong? OK, its written in the GUI, it always use norwegin, yes.

bertfrees commented 6 years ago

That's not the case at the moment. So this issue is probably a duplicate of https://github.com/nlbdev/pipeline/issues/152.

matskober commented 6 years ago

I ran an English book here the other day, unchecking "alltid Norsk", but the t-hat was present there as well ...

On 1 December 2017 at 11:47, Bert Frees notifications@github.com wrote:

That's not the case at the moment. So this issue is probably a duplicate of #152 https://github.com/nlbdev/pipeline/issues/152.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nlbdev/pipeline/issues/154#issuecomment-348475445, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpMMulGJLmUirnx7tlzA_FELZ2DIMSSks5s7-dggaJpZM4QyD5c .

josteinaj commented 6 years ago

Closing as duplicate of #152.

bertfrees commented 6 years ago

But what about what Mats said?

josteinaj commented 6 years ago

Oh, I see. Hyphenation also happens for english books even if force-norwegian is false?