nlbdev / pipeline

NLB branch of the super-project that aggregates all Pipeline related code. See https://github.com/daisy/pipeline for the main branch.
http://repo.nlb.no/pipeline
3 stars 1 forks source link

Capital sign in acronyms with mixed captials and small letters #177

Closed KariRudjord closed 1 year ago

KariRudjord commented 6 years ago

Statped: when acronyms are mixed capitals and small letters the capital sign should be present in front of each capital like this: KrFU: ⠠⠅⠗⠠⠋⠠⠥

Not like this: ⠠⠅⠗⠠⠠⠋⠥

josteinaj commented 1 year ago

@bertfrees is this an issue we can move to the liblouis repo? It sounds like it's not specific to Pipeline 2?

bertfrees commented 1 year ago

Yes, I think we can. Can you first check if there is already a test for this in https://github.com/liblouis/liblouis/blob/master/tests/braille-specs/no_harness.yaml?

josteinaj commented 1 year ago

There's this test:

https://github.com/liblouis/liblouis/blob/1ed46203ad67ee3b49287e5c6a49eec06951786d/tests/braille-specs/no_harness.yaml#L253-L256

  -
    - DTBook NBfU
    - ⠠⠙⠠⠞⠠⠃⠕⠕⠅ ⠠⠝⠠⠃⠋⠠⠥
    - {xfail: true}

But I think maybe there should be a test with a word that ends with multiple captal letters, to be completely sure.

So I added what is described by Kari as a test in this PR: https://github.com/liblouis/liblouis/pull/1429

I'm closing this issue.