search

nlbdev / pipeline

NLB branch of the super-project that aggregates all Pipeline related code. See https://github.com/daisy/pipeline for the main branch.
http://repo.nlb.no/pipeline
3 stars 1 forks source link

Consider removing modules that are not being worked on by NLB #221

Open josteinaj opened 5 years ago

josteinaj commented 5 years ago

We use the latest released versions of most modules. Maybe it would be better to remove the source code for those modules from this repo, both to avoid clutter, but also because we don't really keep them in sync with the official repo anyway.

If there's any of the braille modules we could do this with, that would be great too. Ideally everything NLB-specific should go into NLB-specific modules, and not a fork of shared modules.

bertfrees commented 5 years ago

Now that the modules have been merged into a single repo, it makes no sense anymore to keep certain modules and remove other. It will only make it difficult to sync. Of course you can ditch the whole Pipeline/Dotify/Liblouis source code, but that means from now on you have to wait for new Pipeline/Dotify/Liblouis releases before you can test the changes you have made to it, or even just run the mod-nlb tests against the changes. Being able to test freshly made changes is the big strength of this way of working.

There are almost no NLB specific things in your branch of the Pipeline. Mostly things that are waiting to go upstream, or have gone upstream already. For the one or two things I can think of now that are NLB specific it makes little sense to move to an NLB module I think because it's for example temporarily disabling of broken features. It makes more sense to fix these feature in the Pipeline/Dotify.

josteinaj commented 5 years ago

Ok. Let's not do this then.

bertfrees commented 5 years ago

Doing the sync now... There are a few changes I didn't know about. For example the epub-upgrader module. It's probably better to move this out of the pipeline-script repo. Unless you want to make a PR out of it of course. And I saw some other changes from you that you might want to make PRs from. But wait till I'm done with the sync, then you'll have a better overview of the changes in the NLB branch, and also because I will have rebased some changes.