search

nlesc-dirac / sagecal

SAGECal is a fast, memory efficient and GPU accelerated radio interferometric calibration program. It supports all source models including points, Gaussians and Shapelets. Distributed calibration using MPI and consensus optimization is enabled. Both spectral and spatial priors can be used as constraints. Tools to build/restore sky models are included.
http://sagecal.sourceforge.net
GNU General Public License v2.0
12 stars 8 forks source link

Fix incorrect Gaus scaling with half pi #168

Closed aroffringa closed 1 year ago

aroffringa commented 1 year ago

Sagecal simulates Gaussian sources with an integrated flux density that is ~1.6 times too high. It appears that this is caused by a "half pi" factor that is in the Gaussian prediction unnecessary.

aroffringa commented 1 year ago

Please be sure to test the GPU code -- I haven't done that.

The CPU code now produces the same Gaussians as Dp3 when Gaussians are circular, and Dp3 has been well tested to produce the correct result. I haven't tested whether the projection and non-circular Gaussians work correctly now.

SarodYatawatta commented 1 year ago

Thanks, I will do some more tests and merge this.