nlesc-sherlock / punchcardjs

Punchcard visualization using TypeScript and D3.js
Apache License 2.0
0 stars 0 forks source link

npm run cover generates errors #67

Closed jspaaks closed 8 years ago

jspaaks commented 8 years ago

Expected behavior

no errors

Actual behavior

errors

Steps to reproduce the behavior

code state = 489e7a95859db0b99750767f812f3692df1cd96b

> punchcardjs@1.0.0-alpha.4 jslint /home/daisycutter/github/nlesc-sherlock/punchcardjs
> jslint test/*.js

test/base.dom.js is OK.

test/colormap.unit.js is OK.

test/date-circle.dom.js
 #1 Unexpected '\d'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 292, Pos 45
 #2 Unexpected '\d'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 292, Pos 52
 #3 Unexpected '\.'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 292, Pos 58
 #4 Unexpected '\d'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 292, Pos 60

test/date-rect.dom.js is OK.

test/general.unit.js is OK.

test/weekday-circle.dom.js
 #1 Unexpected '\d'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 296, Pos 45
 #2 Unexpected '\d'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 296, Pos 52
 #3 Unexpected '\.'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 296, Pos 58
 #4 Unexpected '\d'.
    re = new RegExp('^<circle.*r="(\d{1,}|\d{0,}\.\d{1,})".*><\/circle>$'); // Line 296, Pos 60

test/weekday-rect.dom.js is OK.
jspaaks commented 8 years ago

jslint errors when using \d to signify digits and \. to signify any symbol. apparently the right way is to have \\d and \\. instead. Fixed in aee3a660ee54751484eeeb71dfe327a1c1041064, closing this issue.