Move global grid initialisation to C++

nlesc-smcm / i-emic

An implicit Earth system model of intermediate complexity

Apache License 2.0

6 stars 7 forks source link

Move global grid initialisation to C++ #125

Closed merijn closed 3 years ago

merijn commented 4 years ago

Following steps to check nothing breaks:

Adds accessors for Fortran arrays.
Compare TRIOS_Domain position methods with Fortran initialised values.
Add tests for TRIOS_Domain to compare against references so future commits can't break the logic.
Drop Fortran initialisation (this should cause a test to fail, but doesn't)
Enable C++ initialisation.

merijn commented 4 years ago

No clue why travis s still marked as required despite deleting it, but the rest passes. IMO this is ready to merge, unless we wanted to get rid of levitus and topo after all?

merijn commented 4 years ago

@Sbte @erik808 Any objection to merging this?

erik808 commented 4 years ago

No objections, but it's annoying that travis is still there

merijn commented 4 years ago

Yeah, but I haven't been able to figure out how to remove it, annoyingly.