search

nlesc-smcm / i-emic

An implicit Earth system model of intermediate complexity
Apache License 2.0
6 stars 7 forks source link

fix source of lookup error #136

Closed ipelupessy closed 1 year ago

ipelupessy commented 2 years ago

it seems better to validate against the init than against getDefaultPArameters (that one is almost empty) this fixes a problem where the validation goes wrong if "Belos Solver" sublist is present in the newParams

Sbte commented 1 year ago

This is wrong. The init params can only be set at initialization. This also holds for the Belos Solver parameters. Setting it afterward will do nothing, and therefore will throw an error.