search

nlewo / nix2container

An archive-less dockerTools.buildImage implementation
Apache License 2.0
501 stars 45 forks source link

Add writeSkopeoApplication helper. #115

Closed mikepurvis closed 6 months ago

mikepurvis commented 7 months ago

Mentioned in https://github.com/nlewo/nix2container/pull/77#issuecomment-1579042791; not really essential but might be a nice improvement.

Main thing to watch for is that now jq is required for all the little scripts, but it is just a few hundred kb, so I don't think this is a major cost.

nlewo commented 6 months ago

Arf, as expected, the CI fails while it works locally. I don't run the tests with nix build but with nix run :/

I will have to figure out what is happening but it's not related to this PR. So, let's merge it and fix the GitHub CI job later.

Main thing to watch for is that now jq is required for all the little scripts, but it is just a few hundred kb, so I don't think this is a major cost.

No, it's not a major cost.

Thank you for your contributions.