Image Manifest Metadata Lost

nlewo / nix2container

An archive-less dockerTools.buildImage implementation

Apache License 2.0

500 stars 45 forks source link

Image Manifest Metadata Lost #116

Open clushie opened 6 months ago

clushie commented 6 months ago

Thank you for nix2container.

If I'm using pullImage and check the json it doesn't contain data like Env or Labels or Cmd I believe.

Which is sometimes useful information when packaging a docker image.

nlewo commented 6 months ago

Yes, it would be nice and this should be pretty to add: https://github.com/nlewo/containers-image-nix/blob/9d7f33ef0058f4df4c0912025f43c758a3289d76/nix/image.go#L150

clushie commented 6 months ago

Thanks for pointing me to the right line, I was already reading the NewImageFromDir func today, but didn't notice the obvious todo. I'll see if I can make a working PR tomorrow.