search

nlf / bucker

A simple logging library for node.js
82 stars 28 forks source link

express middleware does not get triggered for successful requests #16

Closed calebTomlinson closed 10 years ago

calebTomlinson commented 10 years ago

the express middleware is not working correctly when I end a request by using response.send('body').

so https://github.com/nlf/bucker/blob/master/index.js#L292 never gets called unless an error happens. Meaning that even log level debug doesn't log all requests.

nlf commented 10 years ago

Can you make a short code example showing this problem? response.send('body'); calls response.end, which would cause the middleware to fire. If it's not, that's definitely a bug, but I can't reproduce it here..

calebTomlinson commented 10 years ago

Turns out I fell for the good old fashioned loading middleware out of order problem

Thanks for you time, and the quick response.