search

nlf / bucker

A simple logging library for node.js
82 stars 28 forks source link

Unneeded color reference in file logger #25

Closed consulthys closed 10 years ago

consulthys commented 10 years ago

In the file logger, on line 30 (https://github.com/nlf/bucker/blob/master/lib/file.js#L30), the grey call should be removed for two reasons:

  1. colors are only useful in a console/browser context
  2. the grey decoration (i.e. \x1B[90m and \x1B[39m) produces garbage data in the log file around the tags array

I think it was overlooked otherwise it would be used on lines 38, 58 and 72 as well.

nlf commented 10 years ago

You are absolutely right, that got overlooked when I copied the console transport to create the file one. I'll get it fixed. Thanks for bringing it to my attention.

consulthys commented 10 years ago

Nice job, thanks!