search

nlhkabu / connect

Connect is a moderated web application that helps members connect with each other based on skills, interests and location.
http://whoisnicoleharris.com/connect/
BSD 3-Clause "New" or "Revised" License
46 stars 25 forks source link

Fix PEP8 #24

Closed Natim closed 9 years ago

Natim commented 9 years ago

PEP8 in current master is broken.

ewjoachim commented 9 years ago

Hurray !

ewjoachim commented 9 years ago

Double hurray !

Natim commented 9 years ago

Do you guys can validate that BDD tests are run? I can't tell from the output. Also it is supposed to display the coverage but it doesn't seems to be the case.

nlhkabu commented 9 years ago

@Natim - running ./manage.py test ONLY runs the unit tests. To run the BDD tests you need to do ./manage.py test BDD. However, we currently have failing BDD tests - I am working on fixing this. I have never had coverage working on the BDD folder - is it necessary? I thought coverage was mainly for unit testing??

Natim commented 9 years ago

I thought coverage was mainly for unit testing??

Yes it is not for bdd tests but I does not seems to be running on the unit tests yet either.

https://travis-ci.org/nlhkabu/connect/jobs/65851493#L242

nlhkabu commented 9 years ago

OK - I think we should look into coveralls for this. See #48