Blacklist seems to be ignored

[gs58muse]

Hello Nicolas,

relating to Issue #31 "Problem with Google reCaptcha" I checked the Blacklist-Feature. I tested the Form with : (% contact %) and (% contact: send@mydomain.com, text "Vorname" , text! "Nachname", email! %) In p01-contact "Backend" I defined a Blackist-Field "email" with the Value "test@mydomain.com" (in 1. Fields-checklists-row) The Form will be sent - even if the mail-adress is in the Blacklist. Same action with other Field-Types

Best regards Gerhard

[nliautaud]

Hi Gerhard, thanks for the report.

The error should be in the following method. If you can/want to look at it, printing $list after L166 and $content after L172 should help find the issue.

https://github.com/nliautaud/p01contact/blob/680f08033e6eeda842cdb0c51bf77cbaf483552d/p01-contact/src/P01contact_Field.php#L164-L183

[gs58muse]

Hi Nicolas,

I checked the two vars/arrays "$list" and "$content" in "../src/P01contact_Field.php". I think the function isBlacklisted() is ok (i've found my defined blacklist-values ..)

I think the Error is in "../src/P01contact_Form.php" - "function post() Line 146" it has something to do with the Var "$hasFieldsErrors"

Best regards Gerhard

[nliautaud]

The issue was indeed there. You can pull the fix branch (or apply manually the slight change 0be8be59d295c982270e9b9f2cc46cc7fdb3c3f4 ) https://github.com/nliautaud/p01contact/tree/32-ignored_checklists And I'll merge if everything is fine.

[nliautaud]

Shipped in 1.1.3 https://github.com/nliautaud/p01contact/releases/tag/1.1.3

[gs58muse]

Hello Nicolas,

great Work - both Issue (31 Google Captcha + 32 Blacklist) are solved. I will continue testing on a Live-System

Greetings Gerhard

-----Original Message----- From: Nicolas Liautaud [mailto:notifications@github.com] Sent: Tuesday, April 17, 2018 3:26 PM To: nliautaud/p01contact Cc: gs58muse; Author Subject: Re: [nliautaud/p01contact] Blacklist seems to be ignored (#32)

Shipped in 1.1.3 https://github.com/nliautaud/p01contact/releases/tag/1.1.3

— You are receiving this because you authored the thread. Reply to this email directly, view https://github.com/nliautaud/p01contact/issues/32#issuecomment-381991245 it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/Aj_oDIsp-3ncg-cYh_kyFeuUh7ssr6Wpks5tpe1TgaJpZM4TCfsp the thread. https://github.com/notifications/beacon/Aj_oDBLPdvVbwon-zef7YxxxScQsysNBks5tpe1TgaJpZM4TCfsp.gif