nliautaud / trakttvstats

A chrome extension adding various improvements to trakt.tv
MIT License
29 stars 5 forks source link

wrong matching on some translated posters #38

Open carlosmg2 opened 6 years ago

carlosmg2 commented 6 years ago

I've seen some weird Localized posters matching. I attach 2 images. one with original posters and one with translated. Look the series The Amazing World of Gumball and Modern Family, it matches Gumball with a poster of Sherlock holmes and Modern Family with The secret of the lakes.

I've put in settings language ES for spanish

original posters

bad es posters

nliautaud commented 6 years ago

Thanks for the report.

I'll look into it but as I can't access imdb/tmdb ids on listing views, in that case info retrieval is done trough tmdb search engine which doesn't return a fiability index that I could relate on, so indeed errors may appear, especially with shows.

carlosmg2 commented 6 years ago

Hi,

Thanks for the response. Don't worry if it's not 100% fiable. I understand. Do your best, just wanted to help u improve it a bit.

With dev version i don't see the problem in shows 👌

Movies are ok too,

*but just found an issue with a movie in trakt history tab:

https://trakt.tv/movies/my-king-2015

On this page I see it correctly, translated title and poster. But in history tab I see a weird Thailand name wich points to this movie https://www.themoviedb.org/movie/228008

I see this tranlated ES:

This is its original poster:

but on its page I see correct NAME and POSTERs:

This may be a case of that less fiability u talked about.

Keep up the good work.

2018-03-16 12:49 GMT+01:00 Nicolas Liautaud notifications@github.com:

Thanks for the report.

I'll look into it but as I can't access imdb/tmdb ids on listing views, in that case info retrieval is done trough tmdb search engine which doesn't return a fiability index that I could relate on, so indeed errors may appear, especially with shows.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nliautaud/trakttvstats/issues/38#issuecomment-373690502, or mute the thread https://github.com/notifications/unsubscribe-auth/AFotiKyTXgw_EOyLD0_y4M49irxBYi2Kks5te6bHgaJpZM4SqU4J .

nliautaud commented 6 years ago

Great, the dev version implements some show related localization that may improve it.

I don't see the images you posted, but this issue seems to have the same reason indeed. You can enable debug logs in your browser Developer console by enabling the debug option in the extension settings. They will show you the TMDb search API response returning the wrong movie.

Example by searching directly on TMDb : https://www.themoviedb.org/search/movie?query=My%20King

The extension should also query movies by production date though, so I have to take a look here.

Thanks for the kind words !