nlight-jdev / jcouchdb

Automatically exported from code.google.com/p/jcouchdb
Other
0 stars 0 forks source link

Can't bulk-delete documents that have a space in the id. #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create a few documents with spaces in the id.
2. Add them to a list of documents to delete.
3. call bulkDelete()

What is the expected output? What do you see instead?
Expect to have the documents deleted.  Instead, get an exception from couchdb 
because the 
space isn't escaped properly.

What version of the product are you using? On what operating system?
jcouchdb-0.10.0-1

Please provide any additional information below.

Original issue reported on code.google.com by cory.hac...@gmail.com on 20 Oct 2009 at 9:20

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r224.

Original comment by ff...@gmx.de on 20 Oct 2009 at 9:40

GoogleCodeExporter commented 8 years ago
Thanks.. good catch.

Original comment by ff...@gmx.de on 20 Oct 2009 at 9:40

GoogleCodeExporter commented 8 years ago
I was just rerunning my test cases, and I also can't read a document with a 
space.  Bulk save works... I'll try a 
couple of other scenarios.

Original comment by cory.hac...@gmail.com on 20 Oct 2009 at 9:57

GoogleCodeExporter commented 8 years ago
yeah, save() doesn't work either...  maybe need to escape spaces everywhere we 
escape slashes.

Original comment by cory.hac...@gmail.com on 20 Oct 2009 at 10:03

GoogleCodeExporter commented 8 years ago
since this only happens when doc ids are passed in the URL and this is not 
often the
case in couchdb and since I added the right escaping pretty central it could 
very
well be that we're done with this..

Original comment by ff...@gmx.de on 20 Oct 2009 at 10:05

GoogleCodeExporter commented 8 years ago
create and update were already fixed and tested with the first commit, just 
added
another test for get()

http://code.google.com/p/jcouchdb/source/browse/trunk/test/org/jcouchdb/db/BulkD
eleteWithSpacesTestCase.java

Original comment by ff...@gmx.de on 20 Oct 2009 at 10:08

GoogleCodeExporter commented 8 years ago
Looks good.  Thanks.

Original comment by cory.hac...@gmail.com on 21 Oct 2009 at 12:00