Closed mattparlane closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nlux-docs | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Jun 10, 2024 1:21am |
Thank you for this contribution @mattparlane Merging it
Feel free to apply the same change to the main code base. I'm sure you'll find some continue
statements
Thanks for accepting. The thing is that I don't actually agree that the continue
keyword is a problem, the only reason I thought the sample code should change is that the rule is in eslint's default config, so anyone using eslint in their project would have errors if they copied the sample code (like I did). If you're not using eslint in nlux (or you have that rule disabled), then it's not a problem, so I don't think anything else needs to change.
Fair enough. We're using eslint
on the main codebase, but with different config.
Thanks for fixing it for examples to match default eslint config.
eslint's default rule set includes the
no-continue
rule, which disallows any use of thecontinue
keyword. This keyword is used in the project's sample code.no-continue rule eslint's default rule set
This PR removes the
continue
keyword, and removes thedoneReading
variable from most of the sample code, and is functionally equivalent.