Specify NLTK data directory in Dockerfile and add build test - Githubissues

nlmatics / nlm-ingestor

This repo provides the server side code for llmsherpa API to connect. It includes parsers for various file formats.

https://www.nlmatics.com

Apache License 2.0

1.11k stars 160 forks source link

Specify NLTK data directory in Dockerfile and add build test #86

Open jinkjonks opened 3 months ago

jinkjonks commented 3 months ago

Description of the change

Specify NLTK data directory in Dockerfile when running downloaders for punkt and stopwords.
add a docker build smoke test (sleep at 20s because that seems to be how long it takes to boot up the jar)
Type of change
[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #85

Checklists

Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[x] Issue from task tracker has a link to this pull request

jinkjonks commented 3 months ago

@ansukla @kiran-nlmatics Please review, thanks!

jinkjonks commented 3 weeks ago

Hey @jamesvillarrubia, I've noticed that you've been somewhat active. Can you please take a look at merging this? Cheers!