nlmixr2 / blog

The nlmixr2 blog
0 stars 1 forks source link

Nlmixr2 nonmem #14

Closed billdenney closed 1 year ago

billdenney commented 1 year ago

For reasons I don't understand, this PR is not showing up in the #11 PR. These are on top of that.

The changes include updating Hugo to the current version (blogdown::install_hugo()).

netlify[bot] commented 1 year ago

Deploy Preview for nlmixr ready!

Name Link
Latest commit 95d41ac2ed3549adbcc7469ec9c1f01d6346392d
Latest deploy log https://app.netlify.com/sites/nlmixr/deploys/636fadc218feda000969aa40
Deploy Preview https://deploy-preview-14--nlmixr.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mattfidler commented 1 year ago

You arent picking up Justin's changes. I think that is why. Maybe you can merge the two

billdenney commented 1 year ago

I pulled the current branch, and that didn't seem to have any additional changes. I'm not sure how to make it work.

kestrel99 commented 1 year ago

Hi Bill,

I’ve gone over your pull request line by line and can’t find any differences with the published version. Can you check? In the meantime I’ve merged #11. If something’s missing, can you open a new pull request? I won’t announce the new post until I’ve heard from you.

Best Justin

— Justin Wilkins, PhD — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.com +49 2922 927 8843 @.**@.> linkedin.com/in/justinjwilkinshttps://www.linkedin.com/in/justinjwilkins/

@.***

From: Bill Denney @.> Sent: Saturday, 12 November 2022 16:58 To: nlmixr2/blog @.> Cc: Subscribed @.***> Subject: Re: [nlmixr2/blog] Nlmixr2 nonmem (PR #14)

I pulled the current branch, and that didn't seem to have any additional changes. I'm not sure how to make it work.

— Reply to this email directly, view it on GitHubhttps://github.com/nlmixr2/blog/pull/14#issuecomment-1312514845, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACJAAXX6XPXSGULOHLXGZOLWH647VANCNFSM6AAAAAAR6LBXLU. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

billdenney commented 1 year ago

It was minor. I don't know why it's not showing up. No need to wait for this.