Closed mattfidler closed 2 years ago
netlify[bot]
commented
2 years ago | Name | Link |
|---|---|
| Latest commit | b9f1c252d2983fa0ecab592ca7c341be9920a355 |
| Latest deploy log | https://app.netlify.com/sites/nlmixr/deploys/63516c0c5e62c800093b6760 |
| Deploy Preview | https://deploy-preview-5--nlmixr.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
kestrel99
commented
2 years ago I’ve added some review comments! Let me know if OK. Do we not want to mention somewhere how to fix the CRAN issue when all the packages are not fully in sync? (ie download from r-universe)
— Justin Wilkins, PhD — Upcoming absence: 28 October 2022 – 4 November 2022, inclusive — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.com +49 2922 927 8843 @.**@.> linkedin.com/in/justinjwilkinshttps://www.linkedin.com/in/justinjwilkins/
@.***
From: Matthew Fidler @.> Sent: Wednesday, 19 October 2022 17:17 To: nlmixr2/blog @.> Cc: Justin Wilkins @.>; Review requested @.> Subject: Re: [nlmixr2/blog] rxode2 release (PR #5)
@mattfidlerhttps://github.com/mattfidler requested your review on: #5https://github.com/nlmixr2/blog/pull/5 rxode2 release.
— Reply to this email directly, view it on GitHubhttps://github.com/nlmixr2/blog/pull/5#event-7622720141, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACJAAXVSFXSFLKVEMEKHVXTWEAGITANCNFSM6AAAAAARJHQO54. You are receiving this because your review was requested.Message ID: @.**@.>>
mattfidler
commented
2 years ago Since everything is now in sync I dont think we need to here. It will simply get lost.
On Thu, Oct 20, 2022, 5:41 AM Justin Wilkins @.***> wrote:
I’ve added some review comments! Let me know if OK. Do we not want to mention somewhere how to fix the CRAN issue when all the packages are not fully in sync? (ie download from r-universe)
— Justin Wilkins, PhD — Upcoming absence: 28 October 2022 – 4 November 2022, inclusive — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.com +49 2922 927 8843 @.**@.> linkedin.com/in/justinjwilkinshttps://www.linkedin.com/in/justinjwilkins/
@.***
From: Matthew Fidler @.> Sent: Wednesday, 19 October 2022 17:17 To: nlmixr2/blog @.> Cc: Justin Wilkins @.>; Review requested @.> Subject: Re: [nlmixr2/blog] rxode2 release (PR #5)
@mattfidlerhttps://github.com/mattfidler requested your review on: #5< https://github.com/nlmixr2/blog/pull/5> rxode2 release.
— Reply to this email directly, view it on GitHub< https://github.com/nlmixr2/blog/pull/5#event-7622720141>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ACJAAXVSFXSFLKVEMEKHVXTWEAGITANCNFSM6AAAAAARJHQO54>.
You are receiving this because your review was requested.Message ID: @.**@.>>
— Reply to this email directly, view it on GitHub https://github.com/nlmixr2/blog/pull/5#issuecomment-1285314426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5VWVZZYQ7MYYC3AZOC4DWEEOV5ANCNFSM6AAAAAARJHQO54 . You are receiving this because you were mentioned.Message ID: @.***>
kestrel99
commented
2 years ago OK. If you’re happy with the edits I’ll process the pull request
— Justin Wilkins, PhD — Upcoming absence: 28 October 2022 – 4 November 2022, inclusive — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.com +49 2922 927 8843 @.**@.> linkedin.com/in/justinjwilkinshttps://www.linkedin.com/in/justinjwilkins/
@.***
From: Matthew Fidler @.> Sent: Thursday, 20 October 2022 13:04 To: nlmixr2/blog @.> Cc: Justin Wilkins @.>; Mention @.> Subject: Re: [nlmixr2/blog] rxode2 release (PR #5)
Since everything is now in sync I dont think we need to here. It will simply get lost.
On Thu, Oct 20, 2022, 5:41 AM Justin Wilkins @.<mailto:@.>> wrote:
I’ve added some review comments! Let me know if OK. Do we not want to mention somewhere how to fix the CRAN issue when all the packages are not fully in sync? (ie download from r-universe)
— Justin Wilkins, PhD — Upcoming absence: 28 October 2022 – 4 November 2022, inclusive — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.comhttp://www.occams.com +49 2922 927 8843 @.**@.mailto:***@***.******@***.***> linkedin.com/in/justinjwilkinshttps://www.linkedin.com/in/justinjwilkins/
@.<mailto:@.>
From: Matthew Fidler @.<mailto:@.>> Sent: Wednesday, 19 October 2022 17:17 To: nlmixr2/blog @.<mailto:@.>> Cc: Justin Wilkins @.<mailto:@.>>; Review requested @.<mailto:@.>> Subject: Re: [nlmixr2/blog] rxode2 release (PR #5)
@mattfidlerhttps://github.com/mattfidler requested your review on: #5< https://github.com/nlmixr2/blog/pull/5> rxode2 release.
— Reply to this email directly, view it on GitHub< https://github.com/nlmixr2/blog/pull/5#event-7622720141>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ACJAAXVSFXSFLKVEMEKHVXTWEAGITANCNFSM6AAAAAARJHQO54>.
You are receiving this because your review was requested.Message ID: @.**@.mailto:***@***.******@***.***>>
— Reply to this email directly, view it on GitHub https://github.com/nlmixr2/blog/pull/5#issuecomment-1285314426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5VWVZZYQ7MYYC3AZOC4DWEEOV5ANCNFSM6AAAAAARJHQO54 . You are receiving this because you were mentioned.Message ID: @.<mailto:@.>>
— Reply to this email directly, view it on GitHubhttps://github.com/nlmixr2/blog/pull/5#issuecomment-1285336889, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACJAAXWNM46UZFTFQDKWITTWEERLLANCNFSM6AAAAAARJHQO54. You are receiving this because you were mentioned.Message ID: @.**@.>>
mattfidler
commented
2 years ago Nevermind. Add it back I missed a single delaration
On Thu, Oct 20, 2022, 6:06 AM Justin Wilkins @.***> wrote:
OK. If you’re happy with the edits I’ll process the pull request
— Justin Wilkins, PhD — Upcoming absence: 28 October 2022 – 4 November 2022, inclusive — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.com +49 2922 927 8843 @.**@.> linkedin.com/in/justinjwilkinshttps://www.linkedin.com/in/justinjwilkins/
@.***
From: Matthew Fidler @.> Sent: Thursday, 20 October 2022 13:04 To: nlmixr2/blog @.> Cc: Justin Wilkins @.>; Mention @.> Subject: Re: [nlmixr2/blog] rxode2 release (PR #5)
Since everything is now in sync I dont think we need to here. It will simply get lost.
On Thu, Oct 20, 2022, 5:41 AM Justin Wilkins @.<mailto:@.>>
wrote:
I’ve added some review comments! Let me know if OK. Do we not want to mention somewhere how to fix the CRAN issue when all the packages are not fully in sync? (ie download from r-universe)
— Justin Wilkins, PhD — Upcoming absence: 28 October 2022 – 4 November 2022, inclusive — Occams Kirchnerstraße 22 59457 Werl Germany www.occams.comhttp://www.occams.com +49 2922 927 8843 @.**@.mailto:***@***.******@***.***> linkedin.com/in/justinjwilkins< https://www.linkedin.com/in/justinjwilkins/>
@.<mailto:@.>
From: Matthew Fidler @.<mailto:@.>> Sent: Wednesday, 19 October 2022 17:17 To: nlmixr2/blog @.<mailto:@.>> Cc: Justin Wilkins @.<mailto:@.>>; Review requested @.<mailto:@.>> Subject: Re: [nlmixr2/blog] rxode2 release (PR #5)
@mattfidlerhttps://github.com/mattfidler requested your review on:
5<
https://github.com/nlmixr2/blog/pull/5> rxode2 release.
— Reply to this email directly, view it on GitHub< https://github.com/nlmixr2/blog/pull/5#event-7622720141>, or unsubscribe<
https://github.com/notifications/unsubscribe-auth/ACJAAXVSFXSFLKVEMEKHVXTWEAGITANCNFSM6AAAAAARJHQO54>.
You are receiving this because your review was requested.Message ID: @.**@.mailto:***@***.******@***.***>>
— Reply to this email directly, view it on GitHub https://github.com/nlmixr2/blog/pull/5#issuecomment-1285314426, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAD5VWVZZYQ7MYYC3AZOC4DWEEOV5ANCNFSM6AAAAAARJHQO54>
. You are receiving this because you were mentioned.Message ID: @.<mailto:@.>>
— Reply to this email directly, view it on GitHub< https://github.com/nlmixr2/blog/pull/5#issuecomment-1285336889>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ACJAAXWNM46UZFTFQDKWITTWEERLLANCNFSM6AAAAAARJHQO54>.
You are receiving this because you were mentioned.Message ID: @.**@.>>
— Reply to this email directly, view it on GitHub https://github.com/nlmixr2/blog/pull/5#issuecomment-1285339479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5VWX4VZ2WVEEOCEHOVLTWEERUJANCNFSM6AAAAAARJHQO54 . You are receiving this because you were mentioned.Message ID: @.***>
mattfidler
commented
2 years ago I am happy with it now. I added rxode2 2.0.10, which I also just submitted to CRAN. If you think anything should read differently, let me know.
@kestrel99 can you look at this