search

nlmixr2 / nlmixr2est

nlmixr2 estimation routines
https://nlmixr2.github.io/nlmixr2est/
GNU General Public License v2.0
7 stars 3 forks source link

Feature request: Calculate shrinkage even when the covariance step fails #428

Closed billdenney closed 6 months ago

billdenney commented 7 months ago

When the covariance step fails, the shrinkage is not calculated. The column is blank.

I don't think that the shrinkage should depend on the covariance step, so it would help if it were calculated to show all known about the model.

mattfidler commented 7 months ago

Did you look at fit$shrink or are you saying it isn't in the table of parameter estimates.

billdenney commented 7 months ago

It isn't in the table of parameter estimates.

mattfidler commented 6 months ago

I'm sorry @billdenney I will need a reproducible expression. I just looked at this when looking at the literalFix branch. For me, even when there was not a successful covariance step, the shrinkage was added to the fit.

Once you have a reproducible expression, feel free to open this issue again.