search

nlmixr2 / nlmixr2plot

Plotting support for nlmixr2
https://nlmixr2.github.io/nlmixr2plot/
GNU General Public License v3.0
2 stars 0 forks source link

Simplify censoring text? #19

Closed billdenney closed 1 year ago

billdenney commented 1 year ago

Should we simplify the text used for censoring? Specifically, could the data always indicate if it is left or right censored and drop the column if it doesn't exist (rather than having different cases for left and right censoring).

https://github.com/nlmixr2/nlmixr2plot/blob/094a0b1e74e910f9b6d97b337bd422d8b5882eb1/R/plot.nlmixr2.R#L16-L28

mattfidler commented 1 year ago

It is already dropped when censoring is not present.

I thought the "Censored data" is more understandable to people than "Right" or "Left", but I suppose we could align the terms. I thought it was easier to read for a majority of people.

mattfidler commented 1 year ago

I personally have to think about right vs left myself.

billdenney commented 1 year ago

If it seems like it'd make people think about it more without a benefit of clarity, no need to change it.

mattfidler commented 1 year ago

Sounds fine to me.