nlmixr2 / nlmixr2plot

Plotting support for nlmixr2
https://nlmixr2.github.io/nlmixr2plot/
GNU General Public License v3.0
2 stars 0 forks source link

Preserve the `nlmixr2.save` option handling? #2

Closed billdenney closed 2 years ago

billdenney commented 2 years ago

@mattfidler , In plot.nlmixr2Sim, there is an undocumented option where it will look at the nlmixr2.save option and save the plot if it is set.

I've not used that functionality, so I don't understand its value. But, since it is undocumented, and separate from the main plotting functionality, would it be okay to remove that feature?

mattfidler commented 2 years ago

plot.nlmixr2Sim likely won't work correctly. You can probably remove it entirely for now....

mattfidler commented 2 years ago

The simulation has changed and it is unclear what needs to be happening here.

billdenney commented 2 years ago

Fixed in nlmixr2est