search

nlnwa / veidemann-api

Protobuf defenitions of Veidemann-API
Apache License 2.0
0 stars 2 forks source link

Fix `go` versioning #61

Closed trym-b closed 1 year ago

trym-b commented 1 year ago

The current go versioning does not work as intended, as the latest version is imported as github.com/nlnwa/veidemann-api/go v0.0.0-20230707060218-f1a798aaa910 and not as v1.0.0

maeb commented 1 year ago

I believe it is not trivial to have the go.mod in a subdirectory. See https://github.com/golang/go/issues/34055.

maeb commented 1 year ago

I think a solution is to move the module files go.mod and go.sum to the root of the repository and rename the module path to github.com/nlnwa/veidemann-api. This will not break any import paths, but the module will need to be reimported by any project using it.

maeb commented 1 year ago

Java projects use this repository via jitpack.io and it seems it requires versions without 'v' prefix: https://github.com/jitpack/jitpack.io/issues/384, so to support both go and java we would need to dual tag releases with and without the 'v' prefix. edit: This information may be outdated so it would need to be tested.

maeb commented 1 year ago

This comment seems to suggest that 'v' prefix works with jitpack: https://github.com/jitpack/jitpack.io/issues/407#issue-130646735

If that is the case we should standardize on vX.Y.Z.