Closed nfarid closed 7 months ago
This library lacks a cmake config file, which means it cannot be easily found with find_package. Given that package managers are becoming more used, I believe this should be addressed.
Currently, the vcpkg port uses hacky patches to enable it be to used: https://github.com/microsoft/vcpkg/pull/8458 https://github.com/microsoft/vcpkg/issues/10809 https://github.com/microsoft/vcpkg/pull/10850
This pull request should allows this library to be easily ported to package managers, so such patches aren't needed.
The target name is nlohmann-fifo-map::nlohmann-fifo-map, as that's the one vcpkg users expect.
My commits for the PR were a bit messy, so I've squashed them in 5 commits (from 11).
This library lacks a cmake config file, which means it cannot be easily found with find_package.
Given that package managers are becoming more used, I believe this should be addressed.
Currently, the vcpkg port uses hacky patches to enable it be to used: https://github.com/microsoft/vcpkg/pull/8458 https://github.com/microsoft/vcpkg/issues/10809 https://github.com/microsoft/vcpkg/pull/10850
This pull request should allows this library to be easily ported to package managers, so such patches aren't needed.
The target name is nlohmann-fifo-map::nlohmann-fifo-map, as that's the one vcpkg users expect.