nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
42.97k stars 6.72k forks source link

Clean up custom base class #3899

Open barcode opened 1 year ago

barcode commented 1 year ago

(Second part of the points listed in https://github.com/nlohmann/json/pull/3110#issuecomment-1229141478, the rest is done in a different PR to prevent mixing of separate issues / features)

Also adds a new method as_base_class to make it easier to access members of a custom base class shadowed by nlohmann::basic_json


Pull request checklist

Read the Contribution Guidelines for detailed information.

coveralls commented 1 year ago

Coverage Status

coverage: 100.0%. remained the same when pulling 0f6d47133e5497fc42a9ef8a18291b1835a17eef on barcode:clean_up_custom_base_class into 5d2754306d67d1e654a1a34e1d2e74439a9d53b3 on nlohmann:develop.

barcode commented 1 year ago

Work on this PR is done and it only needs a review.