Closed xvitaly closed 1 year ago
But there's another one with the MR above applied (gcc 13 snapshot 20230122):
make -f tests/CMakeFiles/test-large_json_cpp11.dir/build.make tests/CMakeFiles/test-large_json_cpp11.dir/build
In file included from /var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/thirdparty/doctest/doctest_compatibility.h:6,
from /var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/src/unit-iterators2.cpp:16:
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/src/unit-iterators2.cpp: In function 'void _DOCTEST_ANON_FUNC_2()':
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/src/unit-iterators2.cpp:946:32: error: no match for 'operator==' (operand types are 'doctest::detail::Expression_lhs<std::ranges::reverse_view<std::ranges::ref_view<nlohmann::json_abi_v3_11_2::basic_json<> > >&>' and 'nlohmann::json_abi_v3_11_2::json' {aka 'nlohmann::json_abi_v3_11_2::basic_json<>'})
946 | CHECK(reversed == j_expected);
| ^~ ~~~~~~~~~~
| |
| nlohmann::json_abi_v3_11_2::json {aka nlohmann::json_abi_v3_11_2::basic_json<>}
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/thirdparty/doctest/doctest.h:2099:24: note: in definition of macro 'DOCTEST_ASSERT_IMPLEMENT_1'
2099 | << __VA_ARGS__) DOCTEST_CLANG_SUPPRESS_WARNING_POP
| ^~~~~~~~~~~
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/thirdparty/doctest/doctest.h:2573:20: note: in expansion of macro 'DOCTEST_CHECK'
2573 | #define CHECK(...) DOCTEST_CHECK(__VA_ARGS__)
| ^~~~~~~~~~~~~
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/src/unit-iterators2.cpp:946:17: note: in expansion of macro 'CHECK'
946 | CHECK(reversed == j_expected);
| ^~~~~
In file included from /var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/src/unit-iterators2.cpp:18:
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/include/nlohmann/json.hpp:3691:10: note: candidate: 'template<class ScalarType> requires is_scalar_v<ScalarType> bool nlohmann::json_abi_v3_11_2::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::operator==(ScalarType) const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::json_abi_v3_11_2::adl_serializer; BinaryType = std::vector<unsigned char>]' (reversed)
3691 | bool operator==(ScalarType rhs) const noexcept
| ^~~~~~~~
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/include/nlohmann/json.hpp:3691:10: note: template argument deduction/substitution failed:
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/include/nlohmann/json.hpp:3691:10: note: constraints not satisfied
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/include/nlohmann/json.hpp: In substitution of 'template<class ScalarType> requires is_scalar_v<ScalarType> bool nlohmann::json_abi_v3_11_2::basic_json<>::operator==(ScalarType) const [with ScalarType = std::map]':
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/tests/src/unit-iterators2.cpp:946:17: required from here
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/include/nlohmann/json.hpp:3691:10: required by the constraints of 'template<template<class, class, class ...> class ObjectType, template<class, class ...> class ArrayType, class StringType, class BooleanType, class NumberIntegerType, class NumberUnsignedType, class NumberFloatType, template<class> class AllocatorType, template<class, class> class JSONSerializer, class BinaryType> template<class ScalarType> requires is_scalar_v<ScalarType> bool nlohmann::json_abi_v3_11_2::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::operator==(ScalarType) const'
/var/tmp/paludis/build/dev-libs-json-3.11.2/work/json-3.11.2/include/nlohmann/json.hpp:3690:19: note: the expression 'is_scalar_v<ScalarType> [with ScalarType = doctest::detail::Expression_lhs<std::ranges::reverse_view<std::ranges::ref_view<nlohmann::json_abi_v3_11_2::basic_json<std::map, std::vector, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, long int, long unsigned int, double, std::allocator, nlohmann::json_abi_v3_11_2::adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > > > >&>]' evaluated to 'false'
3690 | requires std::is_scalar_v<ScalarType>
| ~~~~~^~~
Hello, Any update on this?
No. And since we're using GCC 13.0 in our CI as well, I have no idea how to fix this.
No. And since we're using GCC 13.0 in our CI as well, I have no idea how to fix this.
Does it? I may be missing something looking at the jobs, but it looks to me only <=12 is tested, ci_test_compilers_gcc (latest)
seems to be 12 as well, e.g. https://github.com/nlohmann/json/actions/runs/4061409493/jobs/6991615009 -> Run cmake and according to its output gcc claims to be 12.2.0
Yes, you seem to be right.
Any update? 🤔
I am folloing as well. Gcc 13 is coming with Fedora 38 and I would like to be able to compile this library on it
I am currently traveling. If anyone wants to help it would be great. First step would be adding GCC 13 to the CI.
trofi fixed half of this problem in #3895, I'm working on the other half, and it should be done within a few minutes
Fixed this in PR #3966 .The changes in #3895 are not completely merged.
WDYT of releasing json-3.11.3
release? Current latest json-3.11.2
fails to build with already released gcc-13.1.0
. I think develop
is in a reasonable shape.
+1 to next release. GCC 13 is the default system compiler on newer distros, so right now this library will not build on e.g. current Ubuntu.
I am currently having issues running my release script. I will create a bug issue and ask for help bringing this forward.
I am currently having issues running my release script. I will create a bug issue and ask for help bringing this forward.
This: #4197
Description
Build failure under GCC 13.
Reproduction steps
Run standard build with tests enabled against GCC 13.
Expected vs. actual results
Minimal code example
No response
Error messages
Compiler and operating system
GCC 13.0.0, Fedora Linux 38
Library version
3.11.2
Validation
develop
branch is used.