Publish documentation (publish_documentation.yml): not running but it does not to seem due to missing GITHUB_TOKEN permissions. Is there a way to test it better on the main repo?
[x] The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.
Please don't
The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.
Coverage: 100.0%. Remained the same when pulling bb3c7cbd0a5373db8d06ae215aa3b828258a2b6d on joycebrum:develop into bbe337c3a30d5f6eea418b4aee399525536de37a on nlohmann:develop.
Closes #3971
Set top level permissions to all workflows and grant write permission on run level
Tests:
CIFuzz (cifuzz.yml): success https://github.com/joycebrum/json/actions/runs/4377439445
Code scanning - action (codeql.yml): success https://github.com/joycebrum/json/actions/runs/4377391716
macOS (macos.yml): success https://github.com/joycebrum/json/actions/runs/4377439453
Publish documentation (publish_documentation.yml): not running but it does not to seem due to missing GITHUB_TOKEN permissions. Is there a way to test it better on the main repo?
Pull Request Labeler (.github/workflows/labeler.yml): success https://github.com/joycebrum/json/actions/runs/4377439245
Ubuntu (ubuntu.yml): success https://github.com/joycebrum/json/actions/runs/4377391705. The coveralls was also able to comment https://github.com/joycebrum/json/pull/4#issuecomment-1462667118
Windows (windows.yml): success https://github.com/joycebrum/json/actions/runs/4377439449/jobs/7660926326
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.