Closed davidstone closed 11 months ago
(Ignore my comment before. Thanks for looking into the issue!)
(Ignore my comment before. Thanks for looking into the issue!)
Yeah, it's an unfortunate change. #pragma once
is definitely cleaner and less bug-prone. :(
The source code has not been amalgamated. @davidstone Please read and follow the Contribution Guidelines.
The remaining failures are unrelated to my changes. clang 16.0 was just released and it adds a new warning, Wunsafe-buffer-usage
, and that warning is being triggered by existing code.
The ci_cpplint
step is still failing.
@davidstone You probably need to merge in the latest changes to fix the CI.
Newer versions of clang have fixed this bug. If someone else wants to take over this to get the PR working for versions of clang without the fix (I don't know which numbered versions are broken vs. working) feel free, but given that I prefer the way the code is with #pragma once
and there are plenty of other modules bugs fixed in newer versions of clang, I'm happy to just abandon this.
Fixes https://github.com/nlohmann/json/issues/3974 by using the standard-compliant
#ifndef #define #endif
pattern instead of#pragma once
.