nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
42.01k stars 6.63k forks source link

Only expose `include/nlohmann/json.hpp` as public header in Bazel BUILD file #3981

Closed thii closed 1 year ago

thii commented 1 year ago

All other headers are not meant to be included by a client of this library and should be declared in srcs.

This uses https://github.com/bazelbuild/rules_swift/blob/40c36c936c9c80b4aefa3f008ecf99dbe002be2c/third_party/com_github_nlohmann_json/BUILD.overlay as a reference.


Pull request checklist

Read the Contribution Guidelines for detailed information.

coveralls commented 1 year ago

Coverage Status

Coverage: 100.0%. Remained the same when pulling 7cb526e4da4892d68a0938383849e1bb26ff2857 on thii:thi/only-expose-include-nlohmann-json.hpp-as-public-header into 546370c9e778d99e7176641123e5cc1d0b62acab on nlohmann:develop.

gregmarr commented 1 year ago

All other headers are not meant to be included by a client of this library.

That is not an accurate statement in general. The single include is simply an option for those users that want a "simpler" install.

thii commented 1 year ago

Got it. Thanks.