nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
41.46k stars 6.59k forks source link

Added to tests the file unit-algorithm.cpp (c++ 11) functions from algorithm library #4044

Closed Tomerkm closed 1 year ago

Tomerkm commented 1 year ago

Added new tests to the file unit-algorithm.cpp (c++ 11) that were missing at the test:

  1. iota
  2. copy
  3. copy if
  4. copy n

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]


Pull request checklist

Read the Contribution Guidelines for detailed information.

Please don't

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

coveralls commented 1 year ago

Coverage Status

coverage: 100.0%. remained the same when pulling ae144bae3a87a2f5ebbf99719eae7979eebb192e on Tomerkm:develop into 254395e5f7731b5595e7c11ac4b929c923582114 on nlohmann:develop.

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

nlohmann commented 1 year ago

Please run „make amalgamate“ before committing.

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

Tomerkm commented 1 year ago

hi @nlohmann, Thanks for your comment. I just saw it now.

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

nlohmann commented 1 year ago

You originally added way more tests - what was wrong with them?

Tomerkm commented 1 year ago

You originally added way more tests - what was wrong with them?

@nlohmann you are right. Some of the tests i deleted because of the Amalgamation check failed, and some tests have failed in ubuntu but passed in windows. I add them again and see if it works

Tomerkm commented 1 year ago

@nlohmann Hi, I have added the tests again that i deleted before.

nlohmann commented 1 year ago

Thanks!