Add to CONTRIBUTING.md that `make pretty` is required for test updates.

gregmarr commented 1 year ago

Add to CONTRIBUTING.md that make pretty is required for test updates, as not doing so will result in a failure in the amalgamation check.

Pull request checklist

[x] Changes are described in the pull request, or an existing issue is referenced.
[n/a] The test suite compiles and runs without error.
[n/a] Code coverage is 100%. Test cases can be added by editing the test suite.
[n/a] The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

coveralls commented 1 year ago

coverage: 100.0%. remained the same when pulling 3128faed715b74ed0173bf87d31395b9862b92de on gregmarr:patch-1 into a0c1318830519eac027a31edec1a99ce1ae5670e on nlohmann:develop.

nlohmann commented 1 year ago

Oof, Clang-Tidy again has some complaints... I'll check before merging this.

gregmarr commented 1 year ago

The clang-tidy complaints are in files not touched by this PR.

nlohmann commented 1 year ago

Thanks a lot!

nlohmann / json

Add to CONTRIBUTING.md that `make pretty` is required for test updates. #4045

Pull request checklist