nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
41.46k stars 6.59k forks source link

Improve ordered map #4055

Closed Tomerkm closed 1 year ago

Tomerkm commented 1 year ago

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]

  1. I updated the following method: T& at(const key_type& key)

it will call to the following method: const T& at(const key_type& key) const The idea is to remove duplicate code

  1. For each function that has a loop call to the method this->end() several times, I did the following changes: For preventing it be called several times, the returned variable is stored in a variable.

Pull request checklist

Read the Contribution Guidelines for detailed information.

Please don't

github-actions[bot] commented 1 year ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @Tomerkm Please read and follow the Contribution Guidelines.

coveralls commented 1 year ago

Coverage Status

coverage: 100.0%. remained the same when pulling 5190c4d643a519606965feba37e0dab57a2fead1 on Tomerkm:improve_ordered_map into 5d2754306d67d1e654a1a34e1d2e74439a9d53b3 on nlohmann:develop.

Tomerkm commented 1 year ago

Please add a summary of the changes you made and the reason for the changes.

I added summary and explain why I did the changes. Thanks