Closed Nauroze closed 9 months ago
So @nlohmann, I think this change is good enough and supports this CMake build script until CMake 3.27 is deprecated. Can this be merged?
I also think this PR is a pure improvement.
The changes in this PR are insufficient, there are still various CMakeLists.txt
files in the tests
area which need updating as well. The shift all the way up to 3.27 also looks a bit risky to me to take as a single jump all at once. It would take a deeper analysis of all the policies between 3.1 and 3.27 to be sure none of them adversely affect the project.
I just open #4112 before seeing this PR here. My PR only lifts the upper range to CMake 3.14, but I did go through the project's CMake logic and I believe the policy changes are fine between 3.1 and 3.14. I also updated the tests
area. Therefore, I recommend closing this PR here in favour of #4112, which is a safer, more complete change.
@Nauroze What do you think of #4112?
@Nauroze What do you think of #4112?
@nlohmann Yeah I'm good with that, it's more thorough as it is changing the CMakeLists.txt in the test directories as well.
Something to keep in mind: Since it uses 3.14 we have to look at changing this again in a few years if any future deprecation warnings come out. 3.27 would be a change for the long run. But I do understand picking 3.14 was a conservative choice and keeping it safe.
Closed in favor of #4112.
Resolves issue #4076 This commit updates the minimum cmake version 3.16, since 3.5 and below will be deprecated.