search

nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
42.4k stars 6.67k forks source link

Bazel: Improve support for bzlmod #4111

Closed Vertexwahn closed 1 year ago

Vertexwahn commented 1 year ago

The Bazel build system now supports a new way of handling 3rd party dependencies, such as JSON for Modern C++. For this new way, a MODULE.bazel file is needed - in the long term, the WORKSPACE.bazel file will not be needed anymore and will be deleted in the future.

coveralls commented 1 year ago

Coverage Status

coverage: 100.0%. remained the same when pulling 55e16a449f00a51c64acd085ab12d3c88dddc547 on Vertexwahn:bazel-support into 5d2754306d67d1e654a1a34e1d2e74439a9d53b3 on nlohmann:develop.

nlohmann commented 1 year ago

Do I really need to add more files just to support Bazel?

Vertexwahn commented 1 year ago

@nlohmann In the long term MODULE.bazel will replace the WORKSPACE.bazel file. Maybe its to early for this switch. If you do not want to have more Bazel files in your repo we can simply close this PR and I will do the replacement of WORKSPACE.bazel by MODULE.bazel when this is the main way of Bazel to handle 3rd party deps...

nlohmann commented 1 year ago

@nlohmann In the long term MODULE.bazel will replace the WORKSPACE.bazel file. Maybe its to early for this switch. If you do not want to have more Bazel files in your repo we can simply close this PR and I will do the replacement of WORKSPACE.bazel by MODULE.bazel when this is the main way of Bazel to handle 3rd party deps...

Ok.