Fixed basic_json::diff and basic_json::patch not compiling with custom string type (#4134)

nlohmann / json

JSON for Modern C++

https://json.nlohmann.me

MIT License

41.33k stars 6.58k forks source link

Fixed basic_json::diff and basic_json::patch not compiling with custom string type (#4134) #4137

Open tomalakgeretkal opened 10 months ago

tomalakgeretkal commented 10 months ago

Note that this has yet to be amalgamated (waiting for #4083).

tomalakgeretkal commented 10 months ago

Amalgamated.

coveralls commented 9 months ago

coverage: 100.0%. remained the same when pulling 96129bd96d4929aa9818641f6f9b3b77da5379fa on tomalakgeretkal:custom-string-fix into edffad036d5a93ab5a10f72a7d835eeb0d2948f9 on nlohmann:develop.

github-actions[bot] commented 8 months ago

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @tomalakgeretkal Please read and follow the Contribution Guidelines.

tomalakgeretkal commented 8 months ago

Looks amalgamated here :( check-amalgamate works for me!

gregmarr commented 8 months ago

You may be using a different version of astyle that produces different results. The check is using 3.1. We've seen that later versions produce different results.